ship fzf-native by default

nvim-telescope / telescope.nvim

Find, Filter, Preview, Pick. All lua, all the time.

MIT License

15.45k stars 823 forks source link

ship fzf-native by default #988

Open tjdevries opened 3 years ago

tjdevries commented 3 years ago

we can ship it and just check if they have make and gcc or whatever @Conni2461 uses. If not, then we use old terrible sorter I wrote a long time ago, otherwise new fzf sorter.

This would be cool I think. (can be used a submodule maybe? :) )

clason commented 3 years ago

Could we do the same thing in Telescope that https://github.com/nvim-telescope/telescope-fzy-native.nvim does for fzy-native (import as submodule and transparently build on install/upgrade)?

Alternative (short-term) "solution" is to turn fzf-native into a hard requirement like plenary and allow advanced users to override with a different extension (and fail gracefully if fzf-native cannot build).

Conni2461 commented 3 years ago

if we bundle this we could make more use of this by not just putting fzf-native in telescope core but also implementing some of the other stuff we have here in c to improve performance. Just putting a chat protocol here for future reference

https://github.com/jmckaskill/luaffi (unmaintained) https://github.com/facebookarchive/luaffifb (fork "maintained")

Edit: i dont know why some text is highlighted. Ignore that :rofl: