search

nvirm / K8-Gnomish-Queuing-Device

Screen monitoring tool that notifies you when your WoW queue to server is starting to end. Sends a Push message to your mobile device.
2 stars 1 forks source link

Try to validate queue position #6

Open nvirm opened 5 years ago

nvirm commented 5 years ago

Currently we expect that if we can read the queue text properly, there is nothing wrong with the queue position.

What we should probably do, is make a Tuple of the queue positions, including the datetime and position. Then we wouldn't need to rely on qposition.Min() .

Haven't seen any misreads on the position though. It either fails completely or goes OK.

nvirm commented 5 years ago

Not completely making this issue obsolete, but worth noting that the 1.1 release has an improved handling for the screenshot, making it easier for the OCR to work.

nvirm commented 5 years ago

Definitely needs validation, started seeing false positives after imagemagick function

nvirm commented 5 years ago

Also really needs textbased logging to make sure things are translated correctly

nvirm commented 5 years ago

https://github.com/kitsun8/K8-Gnomish-Queuing-Device/commit/6b4aba255891d940150893365976c00c30b1edf1 Handles things a bit better, actual validation still missing (bandaid fix)

nvirm commented 3 years ago

One fast fix would be to add a "suspect" threshold. for queue speed. If for example 700 turns to 70 in 10 seconds time, suspect the input to be non valid, and require... three more scans or so before sending messages, or add "suspect tag" to the push message...