search

nvisionative / nvQuickSite

nvQuickSite is a desktop installation app for DNN, the world's most popular ASP.NET-based CMS. This app allows you to easily install DNN onto any environment that meets the minimum system requirements for DNN to be installed.
http://www.nvquicksite.com
46 stars 14 forks source link

Consider replacing `System.Data.SqlClient` with the newer `Microsoft.Data.SqlClient` #383

Open leedavi opened 3 months ago

leedavi commented 3 months ago

Maybe look at swapping 

using System.Data.SqlClient;

for 

using Microsoft.Data.SqlClient;
david-poindexter commented 3 months ago

@leedavi are you trying to report an issue or something? If so, can you please clarify? The title and description are unclear. Thanks.

leedavi commented 3 months ago

@david-poindexter Sorry, for some reason GitHUb emails always go into my clutter folder and I missed them.

There is no problem. I was just pointing out Microsoft.Data.SqlClient is the replacement of System.Data.SqlClient. I'm sure they'll be no problem for years. From what I recall, it's just a straight swap.

I also noticed your drop database were not using SINGLE_USER, might be an idea to do that.

$"ALTER DATABASE [{this.dbName}] SET SINGLE_USER WITH ROLLBACK IMMEDIATE;DROP DATABASE [{this.dbName}] END";

david-poindexter commented 3 months ago

Thank you for the clarification @leedavi. I will update the issue for clarity. If you want to create another issue for the drop database tip, feel free to do so.