Closed MeganAnneFrench closed 1 year ago
The phosphorous should be considered similar to the nitrogen and now there are inconsistencies in this sense.
yes, it is ok, I forget to write that and I am amending it!
On Tue, 7 Mar 2023 at 10:29, mmolinajack @.***> wrote:
The phosphorous should be considered similar to the nitrogen and now there are inconsistencies in this sense.
— Reply to this email directly, view it on GitHub https://github.com/nvs-vocabs/EMODnetChemVocabs/issues/36#issuecomment-1457837613, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZFHC36W42DJ6NJNUPQTUHDW235W7ANCNFSM6AAAAAAVSGZJVU . You are receiving this because you authored the thread.Message ID: @.***>
Investigating why http://vocab.nerc.ac.uk/collection/P02/current/PXSD/ was deprecated. I agree that it does not look right.
@MeganAnneFrench As you said, we do have Nitrogen concentrations in sediment so one would expect an equivalent category for phosphorus. I can't think of or track back to a reason why PXSD was deprecated (it was deprecated in 2012) so I have re-instated it as it does not really make sense to have it deprecated and replacedBy MIN .
Ok, thanks Gwen!
On Fri, 21 Apr 2023 at 13:00, Gwen Moncoiffé @.***> wrote:
@MeganAnneFrench https://github.com/MeganAnneFrench As you said, we do have Nitrogen concentrations in sediment http://vocab.nerc.ac.uk/collection/P02/current/NTSD/ so one would expect an equivalent category for phosphorus. I can't think of or track back to a reason why PXSD was deprecated (it was deprecated in 2012) so I have re-instated it as it does not really make sense to have it deprecated and replacedBy MIN http://vocab.nerc.ac.uk/collection/P02/current/NTSD/ .
— Reply to this email directly, view it on GitHub https://github.com/nvs-vocabs/EMODnetChemVocabs/issues/36#issuecomment-1517653044, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZFHC35SUSNYFWRJRPCD3HLXCJSEVANCNFSM6AAAAAAVSGZJVU . You are receiving this because you were mentioned.Message ID: @.***>
I have also reviewed the mappings and all "concentration of phosphorus in sediment" codes now point to tp PXSD and not RMIN or MTSD. The only "phosphorus" related codes I kept under RMIN are the "geological" phosphorus because these would not belong to "eutrophication/fertilisation" theme. These codes are: GEOLST22 Concentration of total phosphorus {total_P CAS 7723-14-0} per unit dry weight of geological sample MAJO0010 Proportion of phosphorus (expressed as phosphorus pentoxide) {P_as_P2O5 CAS 7723-14-0} per unit weight of sediment MAJO0021 Proportion of phosphorus (expressed as phosphorus pentoxide) {P_as_P2O5 CAS 7723-14-0} per unit weight of rock MAJO0034 Proportion of phosphorus (expressed as phosphorus pentoxide) {P_as_P2O5 CAS 7723-14-0} per unit weight of geological sample
The changes will be live after our overnight refresh.
I think this can now be closed. Is that right @MeganAnneFrench ?
I agree, yes
On Thu, 18 May 2023 at 16:01, Gwen Moncoiffé @.***> wrote:
I think this can now be closed. Is that right @MeganAnneFrench https://github.com/MeganAnneFrench ?
— Reply to this email directly, view it on GitHub https://github.com/nvs-vocabs/EMODnetChemVocabs/issues/36#issuecomment-1553105833, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZFHC35GIEUUG6IVR3NIFQLXGYTUTANCNFSM6AAAAAAVSGZJVU . You are receiving this because you were mentioned.Message ID: @.***>
Hi, I have attached an Excel file with some suggested changes to P02 and P36 codes relating to P01s for phosphorus (based on the file created by Dick in November 2022 - the non-shaded columns). The yellow shaded columns show the suggested changes and the grey shaded columns are notes. The suggested P02 change relates to a deprecated code: "Phosphorus concentrations in sediment DEPRECATED", but it is unclear why this was deprecated. As the other main nutrient-type element, nitrogen has P02s of "Nitrogen concentrations in sediment" (inorganic nitrogen is mapped here), "Dissolved total and organic nitrogen concentrations in the water column", and "Particulate total and organic nitrogen concentrations in the water column", whereas the active P02s for phosphorus are just "Dissolved total or organic phosphorus concentration in the water column" and "Particulate total and organic phosphorus concentrations in the water column". Phosphorus and nitrogen should be treated in the same way. Megan P02s phosphorus.xlsx