nvs / gem

Gem TD+: A Warcraft III Tower Defense
https://discord.gg/PxNNp77
26 stars 2 forks source link

Patch 1.36.0.20257 causes map to crash before lobby #575

Closed nvs closed 1 year ago

nvs commented 1 year ago

Some change from between 1.36.0.20218 and 1.360.0.20257 causes 1.6.13 to crash before the player is able to enter the lobby. This is the case in both multiplayer and single player. I've confirmed the issue goes back as far as 1.6.6, but is not present in 1.6.5 and earlier in the 1.6 line.

The problem seems to be introduced in 4317950c0783cfc4926b5224c0db77b01dffe572. This makes sense, as it touches the config.j. Add, in fact, the changes to that file are the issue.

This line is the culprit. https://github.com/nvs/gem/blob/558cb892926092263eb70b274b746dcd2ec6a108/src/config.j#L69

This is funny, because this function should be viable within the file. The only offense I can see is that it is not in the correct 'order', according to the common.j. Another thought is that due to the changes to spectators, things are a bit more strict regarding players not defined in the W3I. And these 'extra' computer players are not. Anyways, simple enough to just change player names later in the main.j, which processes during map loading.