search

nylas / nylas-ruby

Ruby bindings for the Nylas Platform APIs
https://nylas.com/docs
MIT License
101 stars 130 forks source link

Update http_client.rb to fix detect_provider problem #469

Closed atejada closed 9 months ago

atejada commented 9 months ago

Description

Detect Provider calls build_query method from Auth.rb instead of http_client.rb. By renaming the private method build_query to build_http_query on http_client.rb the problem is solved.

https://nylas.atlassian.net/browse/TW-2704 https://nylas.atlassian.net/browse/TW-2705

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.84%. Comparing base (67a0b38) to head (7049bf5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #469 +/- ## ======================================= Coverage 99.84% 99.84% ======================================= Files 24 24 Lines 665 665 ======================================= Hits 664 664 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.