search

nysamnang / react-native-raw-bottom-sheet

Add Your Own Component To Bottom Sheet Whatever You Want (Android and iOS)
https://npmjs.com/package/react-native-raw-bottom-sheet
MIT License
1.09k stars 195 forks source link

Please type props with 'PropsWithChildren' #148

Closed fkranenburg closed 8 months ago

fkranenburg commented 2 years ago

Our typescript compiler is complaining about Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<RBSheet> & Readonly<RBSheetProps>'. and it looks like this is because of RBSheetProps is missing PropsWithChildren

guy-shahine commented 2 years ago

This PR fixes the issue https://github.com/nysamnang/react-native-raw-bottom-sheet/pull/146

I've used patch-package for now

gabk17 commented 2 years ago

well, it did not yet, @guy-shahine you guys have to merge it

rick427 commented 2 years ago

Am still having the same issue on my RN typescript project.

guy-shahine commented 2 years ago

@gabk17 I don't have proper permissions to merge, I approved the PR and waiting for the repo maintainers to merge and release a patch

alalfakawma commented 1 year ago

Need this fixed. Hope patch will be released soon.

Arvo-palma commented 1 year ago

Not fixed yet.

rowbot-weisguy commented 1 year ago

@nysamnang please consider merging this PR. It would solve a simple type definition issue for many people without altering any functionality. Thanks!

nysamnang commented 8 months ago

Merged #146