search

nysamnang / react-native-raw-bottom-sheet

Add Your Own Component To Bottom Sheet Whatever You Want (Android and iOS)
https://npmjs.com/package/react-native-raw-bottom-sheet
MIT License
1.09k stars 195 forks source link

Typescript Fix #164

Closed cosmascj closed 8 months ago

cosmascj commented 1 year ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-raw-bottom-sheet@2.2.0 for the project I'm working on.

Here is the diff that solved my problem:


diff --git a/node_modules/react-native-raw-bottom-sheet/index.d.ts b/node_modules/react-native-raw-bottom-sheet/index.d.ts
index 31a5259..c43f9cc 100644
--- a/node_modules/react-native-raw-bottom-sheet/index.d.ts
+++ b/node_modules/react-native-raw-bottom-sheet/index.d.ts
@@ -20,6 +20,8 @@ declare module "react-native-raw-bottom-sheet" {
       draggableIcon?: StyleProp<ViewStyle>;
     };
     keyboardAvoidingViewEnabled?: boolean;
+    children: JSX.Element | JSX.Element[]
+
   };
liyahemanshu commented 1 year ago

Thanks this fixed the type issue

cristo-rabani commented 1 year ago

so, why it's not added?

nysamnang commented 8 months ago

Merged #146