search

nystudio107 / docker-images

Docker image source files
MIT License
13 stars 10 forks source link

Imagick support for PHP8 #2

Open nickdunn opened 3 years ago

nickdunn commented 3 years ago

https://github.com/nystudio107/docker-images/blob/master/php-prod-base/php-8.0-alpine/Dockerfile#L52

Just a quick heads up that a few days ago they published an Imagick version 3.5.0 with PHP8 compatibility. I'm using the following and it seems good so far:

pecl install  imagick-3.5.0
khalwat commented 3 years ago

The problem is, it's apparently incompatible with the Imagine library that Craft uses

So I'm going to stick with the github commit hack until the dust settles. Appreciate the heads up tho!

nickdunn commented 3 years ago

Oh it is? I hadn't gone that far down the rabbit hole — thanks for the tip.

nickdunn commented 3 years ago

Out of interest is there an open bug citing that incompatibility? With Craft 3.7-beta3 and PHP8 and Imagick 3.5.0 everything seems to be working as expected — resizing, cropping etc.

khalwat commented 3 years ago

Looks like it is actually an issue with Craft's Imagine implementation:

https://github.com/avalanche123/Imagine/issues/766

My guess is that they've fixed it in the 3.7 beta

nickdunn commented 3 years ago

And fixed :-)

https://github.com/craftcms/cms/issues/8095

khalwat commented 3 years ago

Nice. I'll re-open this so I remember to add it back in