search

nystudio107 / generator-craftplugin

generator-craftplugin is a Yeoman generator for Craft CMS plugins
MIT License
74 stars 30 forks source link

twig extension classes are deprecated #90

Closed keyurshah closed 4 years ago

keyurshah commented 4 years ago

Hello,

It looks as of twig 2.7, that Twig_Extension is deprecated according to phpstorm.

In researching the issue, it recommended replacing

\Twig_Extension with \Twig\Abstract\Extension

Twig_SimpleFilter with \Twig\TwigFilter

Twig_SimpleFunction with Twig\TwigFunction

https://twig.symfony.com/doc/2.x/deprecated.html

let me know if I should make a pull request. Thanks

thanks.

khalwat commented 4 years ago

It would be FANTASTIC if you could do a pull request for this @keyurshah

khalwat commented 4 years ago

Fixed in https://github.com/nystudio107/generator-craftplugin/commit/a90cb8279cec99b243dca377e3facb62c669ef7b

keyurshah commented 4 years ago

Thanks! Sorry could not get to it. About to launch our commerce store this week hopefully!