search

nytimes / openapi2proto

A tool for generating Protobuf v3 schemas and gRPC service definitions from OpenAPI specifications
Apache License 2.0
964 stars 98 forks source link

Invalid protobuf files in fixtures/ #130

Open curiousleo opened 4 years ago

curiousleo commented 4 years ago

protoc v3.7.1 throws errors when parsing fixtures/accountv1-0.proto:

$ protoc --version
libprotoc 3.7.1
$ protoc -o/dev/null fixtures/accountv1-0.proto
fixtures/accountv1-0.proto:342:14: "Permissions" is already defined in "accountinformationapis.AccountRequest.DataMessage".
fixtures/accountv1-0.proto:646:14: "Permissions" is already defined in "accountinformationapis.CreateAccountRequest.DataMessage".
fixtures/accountv1-0.proto:362:18: "Permissions" is not defined.
fixtures/accountv1-0.proto:672:18: "Permissions" is not defined.
fixtures/accountv1-0.proto:1004:68: "CreateAccountRequest" is not a message type.
fixtures/accountv1-0.proto:1014:20: "GetAccountRequest" is not a message type.
fixtures/accountv1-0.proto:1039:62: "CreateAccountRequest" is not a message type.
$ echo $?
1
curiousleo commented 4 years ago

books.proto is also incomplete:

books.proto:361:26: "GETReviewsFormatRequest" is not defined.
books.proto:361:60: "GETReviewsFormatResponse" is not defined.
curiousleo commented 4 years ago

kubernetes.proto has over a thousand "... is not defined" errors.

Note: the updated kubernetes.proto in https://github.com/nytimes/openapi2proto/pull/129 passes protoc validation.

curiousleo commented 4 years ago

See https://travis-ci.org/github/nytimes/openapi2proto/jobs/728735641#L158 for all validation failures on master.