nytimes / openapi2proto

A tool for generating Protobuf v3 schemas and gRPC service definitions from OpenAPI specifications
Apache License 2.0
964 stars 98 forks source link

Change generated names #73

Closed lestrrat closed 6 years ago

lestrrat commented 6 years ago

Handles name components in snake case like_this to map to gRPC names LikeThis, instead of Like_this.

Still hackish, but at least there are some more tests, and satisfies #41

fixes #41

lestrrat commented 6 years ago

@jprobinson oops, I accidentally merged fixes to #58 in this branch. Ah well.

If this is problematic, I will redo the PR(s).

Meanwhile, I need to check with you about the implementation of these PRs. The code is starting to do a bit of refactoring, and in fact it exposes a few more data types, and changes syntax for a few helper methods -- which could be problematic if you are using this code as a library for another app.


Maybe this is something I should write in a different issue/PR, but if it's OK with you, after this PR I'd like to do some refactoring on the code so I can more easily fix problems if I find them in the future. A few things I intend to do:

Anyways, let me know what you think.