Lazy evaluation on avail error list - Githubissues

nyx-space / nyx

Nyx is a high fidelity, fast, reliable and validated astrodynamics toolkit library written in Rust and available in Python

https://nyxspace.com

GNU Affero General Public License v3.0

196 stars 20 forks source link

Lazy evaluation on avail error list #274

Closed cmleinz closed 10 months ago

cmleinz commented 10 months ago

Effects

Lazily evaluate the avail error list to keep the happy path free of unnecessary allocations.

If this is a new feature or a bug fix ...

[ ] Yes, the branch I'm proposing to merge is called issue-xyz where xyz is the number of the issue.

If this change adds or modifies a validation case

[ ] No.
[ ] Yes and:
- I have coded up, or updated, an existing test case; and
- I have provided a GMAT script which confirms the result(s); and
- I have updated the VALIDATION.md file with the new error data between nyx and GMAT.
- I will specify the version of GMAT used for the validation.

ChristopherRabotin commented 10 months ago

Looks good, thanks! I'll be starting to integrate ANISE in Nyx shortly, but that will likely take several weeks.

I'm a bit surprised about the docker error in the packaging step of python. I suspect that's because you don't own the repo, so I'll ignore that issue and expect it to resolve itself.