Flatten branching loop in b_plane calc - Githubissues

nyx-space / nyx

Nyx is a high fidelity, fast, reliable and validated astrodynamics toolkit library written in Rust and available in Python

https://nyxspace.com

GNU Affero General Public License v3.0

196 stars 20 forks source link

Flatten branching loop in b_plane calc #275

Closed cmleinz closed 5 months ago

cmleinz commented 10 months ago

Effects

This is mostly a stylistic change, feel free to disregard. Helps unify similar code across two branches

If this is a new feature or a bug fix ...

[ ] Yes, the branch I'm proposing to merge is called issue-xyz where xyz is the number of the issue.

If this change adds or modifies a validation case

[x] No.
[ ] Yes and:
- I have coded up, or updated, an existing test case; and
- I have provided a GMAT script which confirms the result(s); and
- I have updated the VALIDATION.md file with the new error data between nyx and GMAT.
- I will specify the version of GMAT used for the validation.

cmleinz commented 10 months ago

Sorry for working GitHub actions unnecessarily! I'll look this over in the morning to see what invariants I'm violating.

ChristopherRabotin commented 5 months ago

Done in #305