search

nyx-space / nyx

Nyx is a high fidelity, fast, reliable and validated astrodynamics toolkit library written in Rust and available in Python
https://nyxspace.com
GNU Affero General Public License v3.0
196 stars 20 forks source link

Fix hifitime-v4 core dependency #301

Closed gwbres closed 6 months ago

gwbres commented 6 months ago

Hello,

coud you please set the hifitime branch to "master" in the v4-branch ? I don't know what the exact behavior is when we do not specify the branch of a git repo. I'm facing issues including both Nyx-v4 and hifitime:master at the same time

ChristopherRabotin commented 6 months ago

What is the error you're encountering? I just updated that branch, so I hope it works now.

gwbres commented 6 months ago

thank you, it can only improve things.

What is the error you're encountering

nyx::Epoch differs from all other Epochs, even though every one points to hifitime:master.

But nyx:hifitime/v4 no longer builds. Maybe that was the root cause, it's sometimes complicated to get cargo to really use the correct branch. It looks like cargo update that you taught me is the best thing to do.

You will have to merge my PR, regex needs to be updated