search

o1-labs / o1js

TypeScript framework for zk-SNARKs and zkApps
https://docs.minaprotocol.com/en/zkapps/how-to-write-a-zkapp
Apache License 2.0
500 stars 110 forks source link

Revert ECDSA hash/packing logic to previous iteration #1669

Closed MartinMinkov closed 3 months ago

MartinMinkov commented 4 months ago

This PR reverts the changes made in https://github.com/o1-labs/o1js/pull/1376 and https://github.com/o1-labs/o1js/pull/1377/ due to a vulnerability found in the ECSDA logic and how a vulnerability can occur when unpacking data in a specific way.