o1-labs / zkapp-cli

CLI to create a zkApp (zero-knowledge app) for Mina Protocol
https://docs.minaprotocol.com/zkapps/how-to-write-a-zkapp
Apache License 2.0
114 stars 43 forks source link

feature: add ability to modify a deploy alias #508

Open barriebyron opened 10 months ago

barriebyron commented 10 months ago

Right now, the zkApp CLI creates a deploy alias with zk config https://docs.minaprotocol.com/zkapps/tutorials/deploying-to-a-network#deploy-alias

However, we are unable to modify an existing deploy alias

It's likely that developers will want to modify existing deploy aliases as they iterate on their development

Enhancement suggestion: add the ability to modify an existing deploy alias (present the current values and change only the ones you want to change)

mitschabaude commented 10 months ago

fwiw you can modify an existing alias by changing the config.json

barriebyron commented 10 months ago

@ymekuria wdyt about documenting the config.json file and adding docs that describe this modify step?

version | 1
-- | --
deployAliases |  
berkeley |  
url | "https://proxy.berkeley.minaexplorer.com/graphql"
keyPath | "keys/berkeley.json"
feepayerKeyPath | "/Users/barriebyron/.cache/zkapp-cli/keys/03-deploy2.json"
feepayerAlias | "03-deploy"
fee | "0.1"
smartContract | "Square"
barriebyron commented 10 months ago

feedback from Ivan at MF presents an attractive option:

If I want to change an existing deploy config, for example alias or endpoint - I should do it manually or create a new one? Would be great to have smth like “zk config set url=