o19s / hello-nlp

A natural language search microservice
Other
96 stars 12 forks source link

Suggest to loosen the dependency on httpx #33

Open Agnes-U opened 2 years ago

Agnes-U commented 2 years ago

Hi, your project hello-nlp(commit id: df89ee6426c0810c28c8cdd2670f48e259d224f4) requires "httpx==0.15.4" in its dependency. After analyzing the source code, we found that the following versions of httpx can also be suitable, i.e., httpx 0.15.0, 0.15.1, 0.15.2, 0.15.3, 0.15.5, since all functions that you directly (1 APIs: httpx._client.AsyncClient.init) or indirectly (propagate to 39 httpx's internal APIs and 20 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on httpx from "httpx==0.15.4" to "httpx>=0.15.0,<=0.15.5". This will improve the applicability of hello-nlp and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on httpx?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?