search

o2r-project / containerit

Package an R workspace and all dependencies as a Docker container
https://o2r.info/containerit/
GNU General Public License v3.0
290 stars 29 forks source link

Typos in containerit.Rmd #181

Closed esther-lyondelsordo closed 3 years ago

esther-lyondelsordo commented 4 years ago

Hello!

I was reading the article posted here: https://o2r.info/containerit/articles/containerit.html which I understand to be a version of containerit.Rmd. There are a couple typos, such as "A dublicate key overwrites existing ones." in Section 4.1, line 327, with should be "A duplicate key overwrites existing ones." I'll comment where I found other typos if I can locate them again.

nuest commented 4 years ago

Hi @esther-lyondelsordo ! Thanks for pointing those out. Let me know when you've found the other ones. I would of course be grateful for a pull request, but can also make the corrections myself, if you prefer.

esther-lyondelsordo commented 4 years ago

I'm kind of new to this, how do I make a pull request? Last time I tried it said I didn't have permission?

On Wed, May 27, 2020 at 1:33 AM Daniel Nüst notifications@github.com wrote:

Hi @esther-lyondelsordo https://github.com/esther-lyondelsordo ! Thanks for pointing those out. Let me know when you've found the other ones. I would of course be grateful for a pull request, but can also make the corrections myself, if you prefer.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/o2r-project/containerit/issues/181#issuecomment-634483815, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJJ4LQ2HXY65EDMW7MAIDTRTS65RANCNFSM4NLHF3ZA .

esther-lyondelsordo commented 4 years ago

Mr. Nust,

Also, I found containerit when I was looking for a way to achieve persistence of R objects in a Docker container. I wonder if you would be able to help. Here is a link to my specific question on Stack Overflow: https://stackoverflow.com/questions/62052919/how-to-persist-an-r-workspace-across-multiple-cmd-statements-in-a-dockerfile. Thanks so much.

Sincerely,

Esther

On Wed, May 27, 2020 at 3:13 PM Esther Lyon Delsordo < esther.lyondelsordo@gmail.com> wrote:

I'm kind of new to this, how do I make a pull request? Last time I tried it said I didn't have permission?

On Wed, May 27, 2020 at 1:33 AM Daniel Nüst notifications@github.com wrote:

Hi @esther-lyondelsordo https://github.com/esther-lyondelsordo ! Thanks for pointing those out. Let me know when you've found the other ones. I would of course be grateful for a pull request, but can also make the corrections myself, if you prefer.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/o2r-project/containerit/issues/181#issuecomment-634483815, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJJ4LQ2HXY65EDMW7MAIDTRTS65RANCNFSM4NLHF3ZA .

nuest commented 4 years ago

No worries, I'd be glad to help you get started in collaborative software development!

You can find a nice (and somewhat tailored for scientists) introduction into GitHub in this article: https://journals.plos.org/ploscompbiol/article?id=10.1371/journal.pcbi.1004947 Rule 3 would be particularly useful here.

I also tried to understand your proble on Stackoverflow - hope it helps!

esther-lyondelsordo commented 4 years ago

Thanks so much! I'll check out that article. Also, your answer on Stackoverflow was very helpful, it gives me more options when passing environment variables into R scripts via docker containers! Thanks a million

On Tue, Jun 2, 2020 at 2:23 AM Daniel Nüst notifications@github.com wrote:

No worries, I'd be glad to help you get started in collaborative software development!

You can find a nice (and somewhat tailored for scientists) introduction into GitHub in this article: https://journals.plos.org/ploscompbiol/article?id=10.1371/journal.pcbi.1004947 Rule 3 would be particularly useful here.

I also tried to understand your proble on Stackoverflow - hope it helps!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/o2r-project/containerit/issues/181#issuecomment-637376408, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJJ4LWZHIL4WJBRTWRKNP3RUSZGXANCNFSM4NLHF3ZA .

nuest commented 4 years ago

I'm glad it was helpful!

Looking forward to your pull request, if your intrigued to try that out, or just post them here and I make the changes to the file.

esther-lyondelsordo commented 4 years ago

I'll go ahead and submit a pull request

On Wed, Jun 3, 2020 at 10:53 AM Daniel Nüst notifications@github.com wrote:

I'm glad it was helpful!

Looking forward to your pull request, if your intrigued to try that out, or just post them here and I make the changes to the file.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/o2r-project/containerit/issues/181#issuecomment-638322664, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJJ4LR72ZACYB5OX7KE6NDRUZ5YDANCNFSM4NLHF3ZA .

esther-lyondelsordo commented 4 years ago

I submitted a pull request. It looks like it wasn't accepted though.

On Wed, Jun 3, 2020 at 10:56 AM Esther Lyon Delsordo < esther.lyondelsordo@gmail.com> wrote:

I'll go ahead and submit a pull request

On Wed, Jun 3, 2020 at 10:53 AM Daniel Nüst notifications@github.com wrote:

I'm glad it was helpful!

Looking forward to your pull request, if your intrigued to try that out, or just post them here and I make the changes to the file.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/o2r-project/containerit/issues/181#issuecomment-638322664, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJJ4LR72ZACYB5OX7KE6NDRUZ5YDANCNFSM4NLHF3ZA .