search

o3de / ROSConDemo

A robotic fruit picking demo project for O3DE with ROS 2 Gem
Other
63 stars 21 forks source link

Update CMakeLists.txt #270

Closed floroeske closed 7 months ago

floroeske commented 7 months ago

Change Gem::AtomLyIntegration_CommonFeatures.Editor.Static to Gem::CommonFeaturesAtom.Editor.Static to match latest o3de-extras https://github.com/o3de/o3de-extras/commit/bbb0da75e6b21216b8dd81c6d95f772390e7613e.

floroeske commented 7 months ago

No problem. Thanks for clearing that up.

It wasn't clear to me which branches of o3de, o3de-extras and ROSConDemo are supposed to work together. The ROSConDemo readme on the main branch states, use the development branch (https://github.com/o3de/ROSConDemo/blob/main/README.md?plain=1#L58). I guess that created a bit of confusion. So I just used development everywhere.

I'll try again with o3de (main), o3de-extras(main) and ROSConDemo(development).

jhanca-robotecai commented 7 months ago

Thank you for pointing that out, it is a mistake on our side. Please use the development branch of this demo, the main branch is one year old and, most probably, will not work correctly. I will fix this after o3de point release (next week).

jhanca-robotecai commented 7 months ago

One more comment: it should be possible to run this demo from the docker files. Those were checked recently.