o3de / o3de

Open 3D Engine (O3DE) is an Apache 2.0-licensed multi-platform 3D engine that enables developers and content creators to build AAA games, cinema-quality 3D worlds, and high-fidelity simulations without any fees or commercial obligations.
https://o3de.org
Other
7.88k stars 2.22k forks source link

Component cards are missing icons and several categories need to be updated #3565

Open superkitcath opened 3 years ago

superkitcath commented 3 years ago

During the rev the engine test WF6: Multiplayer usability test with an SDE, the following issue was logged.

Currently all of the Atom component cards are missing icons and using the default (no icon, icon)

------ Updated AC: ------- CC'ing @alexmontAmazon @cgalvan @AMZN-daimini @mbalfour-amzn @HogJonny-AMZN

During our most recent review of the icons several issues were identified and also corrected. Please use the list below to update the issues. Please ping me directly to get icon export location. @rainbj

  1. We have identified a bunch of icons for components that are not valid in O3DE but are still valid in LY 1.x. So we can remove any icons that have been tagged as “LY 1.x features not in O3DE” in the design doc below. We will keep a copy of these icons inside the O3DE library in case we want to rebuild these features in the future. However for now we can remove them.
  2. We have identified several new categories and incorrectly classified categories ( Categories are seen using the Add component button in the inspector to help find features more quickly). O3DE staff and I have helped create a few new categories as well as remove a few not needed anymore. Example. All the new Atom icons were being classified as “Atom” but the feature itself is not Atom. They should be broken across several categories including lights, rendering, etc. You can see the new categories listed in the swim lanes of the design doc below.
Old Category Name New Category Name
Other Editor
None:New PostFX
None:New Terrain
Modifers Gradient Signal
None:New Lights
  1. If an icons title is marked with red text this means it was recently added to this category and or move from a previous category. Most of the icons are new however there are a few that have been moved.
  2. The icon that have a pink background means these icons are still in progress and coming soon. However we know the name and category of these icons so their default location can set now.

Current version as of 11/19/21 image

rainbj commented 3 years ago

Component icons

@wintermute-motherbrain So I've created all the icons for this ticket. Please see the "Atom" swim lane on the attached image. However the more I think about it, the more I believe Atom should not be it's own category (icon color). We should put each Atom feature in its respective category (feature). I've enlisted the help of @HogJonny-AMZN. Jonny when you get a moment will you go through all the new Atom icons and let me know how I should disburse each of the icons. For example Atom/Mesh = Rendering (I'm guessing). I've also highlighted in Yellow a few icons that appear to have duplicates. Please let me know if this correct or if this is a replacement feature and we should remove the old icon.

amzn-leenguy commented 3 years ago

Hi @rainbj , @HogJonny-AMZN and I did the exercise today and we rearrange them with notes. Attach below is the jpeg output of our discussion and also in text form too. Thanks moving-things-around-for-atom

Editor Grid Occlusion Culling Plane Entity Reference

Env Decal DefferedFog Hdri Skybox Physical Sky

PostFX Display Mapper

PostFX Layer

(post fx operations - will grow over time)
Bloom
Depth of Field
Exposure Control
Look Modification
SSAO (Ambient Occlusion)

(these modify the weight/alpha/masking of postfx)
Gradient    Weight Modifier
Shape       Weight Modifier
Radius      Weight modifier

Lighting Diffuse Probe Grid Directional Light Light (component, all area light types) Global Sky Light Reflection Probe

Rendering Mesh Material

Rendering Deprecation! (no longer exists) Area Light now: Light (old) decal now: Env:Decal Environment probe Now: DiffuseProbeGrid + ReflectionProbe Geometry Cache Future: Alembic High Quality Shadow new: per-'light' quality settings Lens Flares Future: New Lens Flares Lightning Arc OccluserArea *Particle PointLight now: light Portal Projector Light now: light VisArea RenderToTexture VideoPlayback

HogJonny-AMZN commented 3 years ago

@rainbj reassigned to you, grab me if you need more info!

rainbj commented 3 years ago

Thanks @HogJonny-AMZN and @amzn-leenguy for working on this. One small question out of this Jonny. You suggested "removing" rendering. However that is one of the categories that comes up underneath the component menu. Are you suggesting we rename this category or actually removing it. If it's renaming it. Any suggestions on the new name? if we remove it, we need to talk about the new Atom components that were suggested to be put in that grouping. Thanks. Josh

rainbj commented 2 years ago

@alexmontAmazon When you get a moment it would be great to get an owner assigned to this bug. I don't want to attach a bunch of icons to a ticket so it would be good to start working out these details with someone specific. This way we can go back and forth much quicker. Let me know when you have someone in mind with some availability and I'll make my own ticket and block out time on my side to work in parallel with the developer. Thanks.

rainbj commented 2 years ago

Inspector menu

I would also like to include this image which calls attention to how much this category issue is all over the place. Please note the multi colored icons in one section. This is highlighting the current issues. Each category should be a single color