search

oVirt / ovirt-ansible-hosted-engine-setup

Apache License 2.0
33 stars 43 forks source link

Use singular form for oVirt ansible modules (ansible 2.8) #33

Closed tiraboschi closed 5 years ago

tiraboschi commented 6 years ago

All the oVirt related modules are going to be renamed with singular form for ansible 2.8 and now we see a deprecation message:

2018-11-20 09:43:23,394-0500 DEBUG otopi.ovirt_hosted_engine_setup.ansible_utils ansible_utils._process_output:94 host_result_up_check: {u'deprecations': [{u'msg': u"The 'ovirt_hosts_facts' module is being renamed 'ovirt_host_facts'", u'version': 2.8}], 'attempts': 19, u'changed': False, u'ansible_facts': {u'ovirt_hosts': [{u'comment': u'', u'update_available': False, u'protocol': u'stomp', u'affinity_labels': [], u'hooks': [], u'cluster': {u'href': u'/ovirt-engine/api/clusters/1402ac0c-ecd2-11e8-9ef1-5452c0a8c863', u'id': u'1402ac0c-ecd2-11e8-9ef1-5452c0a8c863'}, u'href': u'/ovirt-engine/api/hosts/a6ad8e09-26b8-4d6d-8205-4748919aa447', u'devices': [], u'id': u'a6ad8e09-26b8-4d6d-8205-4748919aa447', u'external_status': u'ok', u'statistics': [], u'certificate': {u'organization': u'lago.local', u'subject': u'O=lago.local,CN=lago-he-basic-ansible-suite-master-host-0'}, u'nics': [], u'iscsi': {u'initiator': u'iqn.2014-07.org.lago:lago-he-basic-ansible-suite-master-host-0:lago-he-basic-ansible-suite-master-host-0'}, u'cpu': {u'speed': 2397.0, u'name': u'Intel Xeon E312xx (Sandy Bridge)', u'topology': {u'cores': 1, u'threads': 1, u'sockets': 2}}, u'port': 54321, u'hardware_information': {u'version': u'RHEL 7.5.0 PC (i440FX + PIIX, 1996)', u'uuid': u'2DD014B0-3210-4653-AE5D-D8787B03AB4A', u'family': u'Red Hat Enterprise Linux', u'product_name': u'KVM', u'supported_rng_sources': [u'hwrng', u'random'], u'manufacturer': u'Red Hat'}, u'version': {u'full_version': u'vdsm-4.30.2-11.git6c62ff1.el7', u'revision': 0, u'major': 4, u'minor': 30, u'build': 2}, u'memory': 5673844736, u'ksm': {u'enabled': False}, u'se_linux': {u'mode': u'enforcing'}, u'type': u'rhel', u'status': u'up', u'tags': [], u'katello_errata': [], u'external_network_provider_configurations': [], u'ssh': {u'port': 22, u'fingerprint': u'SHA256:+jGoKFmwcsZaj+HagLa/NWmYzJ0LiozMZQqxomsxDg4'}, u'address': u'lago-he-basic-ansible-suite-master-host-0', u'numa_nodes': [], u'device_passthrough': {u'enabled': False}, u'unmanaged_networks': [], u'permissions': [], u'numa_supported': False, u'libvirt_version': {u'full_version': u'libvirt-3.9.0-14.el7_5.8', u'revision': 0, u'major': 3, u'minor': 9, u'build': 0}, u'power_management': {u'kdump_detection': True, u'enabled': False, u'pm_proxies': [], u'automatic_pm_enabled': True}, u'name': u'lago-he-basic-ansible-suite-master-host-0', u'max_scheduling_memory': 5337251840, u'summary': {u'active': 1, u'migrating': 0, u'total': 1}, u'auto_numa_status': u'disable', u'transparent_huge_pages': {u'enabled': True}, u'network_attachments': [], u'os': {u'version': {u'full_version': u'7 - 5.1804.el7.centos', u'major': 7}, u'type': u'RHEL', u'custom_kernel_cmdline': u'', u'reported_kernel_cmdline': u'BOOT_IMAGE=/vmlinuz-3.10.0-862.2.3.el7.x86_64 root=UUID=548a847d-dc36-462c-b6e0-3b3578098519 ro console=tty0 rd_NO_PLYMOUTH crashkernel=auto console=ttyS0,115200 LANG=en_US.UTF-8'}, u'storage_connection_extensions': [], u'kdump_status': u'disabled', u'spm': {u'priority': 5, u'status': u'none'}}]}, 'failed': False}

Let's consume them with singular form name only. eg: ovirt_hosts_facts -> ovirt_host_facts ovirt_storage_domains_facts -> ovirt_storage_domain_facts ovirt_storage_domains -> ovirt_storage_domain ovirt_vms -> ovirt_vm ovirt_vms_facts -> ovirt_vm_facts ...

tiraboschi commented 5 years ago

Fixed with #50