search

oakmac / vscode-parinfer

Parinfer for VS Code
MIT License
167 stars 20 forks source link

Port from atom-parinfer #10

Closed roman01la closed 7 years ago

roman01la commented 8 years ago

Hi!

Current vscode-parinfer uses an old version of Parinfer and it doesn't work good. I've ported a great atom-parinfer plugin to VS Code and updated Parinfer to v2.0.10.

It would be great to have this merged. I've been using Atom and now switched to Code and this plugin is the essential tool.

Thanks!

indiejames commented 7 years ago

Please take a look at this and merge it soon. I cloned roman01la's repository to test this and it is a big improvement over the current master.

shaunlebron commented 7 years ago

@narma: would you mind if I took ownership of this project?

Parinfer core is pretty close to complete now after a year of focusing on that. I'd like to maintain a good plugin to make use of it now and help with big PRs like this.

Thanks for upgrading it and picking it up last year. Let me know if you wanna hand off the torch. Glad to take it.

narma commented 7 years ago

@shaunlebron Sure! Thanks for catching this up. I mostly write Scala code rather than Clojure, and for Clojure now using Cursive (mostly) instead of vscode.

narma commented 7 years ago

@shaunlebron I can't transfer ownership because of shaunlebron/vscode-parinfer already exists

shaunlebron commented 7 years ago

@narma: just deleted my fork, should be clear for the transfer now, thanks

shaunlebron commented 7 years ago

@roman01la I'll publish this tonight after I figure it out

shaunlebron commented 7 years ago

published, will try to get the obsolete parinfer packages removed from marketplace to avoid confusion

oakmac commented 7 years ago

@roman01la This is a great improvement to vscode-parinfer. Thank you for doing this work!