search

oaksandspokes / raleighbikeways

Raleigh Bikeways
https://map.oaksandspokes.com
The Unlicense
5 stars 2 forks source link

Current location not working #18

Closed bmweis closed 4 years ago

bmweis commented 4 years ago

I believe the crosshairs are meant to be able to find your current location. If so, this doesn’t seem to be working on my mobile device (iPhone 7). I typically use FireFox but happened to be testing this in Safari in Private mode since I found the page via your tweet and that is the default browser for twitter links. You might want to try testing all of these buttons in the various browsers in both private and non-private mode.

oaksandspokes commented 4 years ago

Could you describe what is happening?

bmweis commented 4 years ago

When I click on it, nothing happens. Like nothing at all.

If I try double-clicking on it with my thumb, the screen zooms in and I can’t zoom back out. But that may be a separate issue. Here’s a screenshot of the zoom issue (which should be a separate issue). 7E614FC8-4AD0-4F71-893D-8C1A7C3CC4BD

oaksandspokes commented 4 years ago

So I installed Firefox on my phone, and was able to reproduce the issue by blocking location tracking to the site. Please make sure location tracking is allowed both for Firefox and the site, and I will work on adding an error message.

For me to turn it back on a clicked the lock near the URL

oaksandspokes commented 4 years ago

For the zoom issue I created a fix for that recently, though it could have not worked on iPhone Firefox. Could you refresh and see if it still happens? Thanks for letting me know about all these problems! I know they are a pain and I don't want people to have to deal with them

bmweis commented 4 years ago

Jackpot on both fronts! I forgot I’d really tightened down the security settings on my phone. I now have location sharing enabled for Firefox.

Btw, I hope all my GH issues aren’t driving you too crazy :)

On Sat, Jan 4, 2020 at 7:30 PM oaksandspokes notifications@github.com wrote:

For the zoom issue I created a fix for that recently, though it could have not worked on iPhone Firefox. Could you refresh and see if it still happens? Thanks for letting me know about all these problems! I know they are a pain and I don't want people to have to deal with them

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oaksandspokes/raleighbikeways/issues/18?email_source=notifications&email_token=AEWN5HRKFVJZIEVOKALTTB3Q4ES4BA5CNFSM4KCXLY62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIDDN4I#issuecomment-570832625, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWN5HXXRTTBP7VHBXZTJMLQ4ES4BANCNFSM4KCXLY6Q .

-- Brian M. Weisberg - Head of Finance & Biz Ops www.tidelift.com Twitter https://twitter.com/bmweis | LinkedIn https://www.linkedin.com/in/brian-weisberg-b966894

oaksandspokes commented 4 years ago

I appreciate the feedback! I think this is fixed by PR #22, I added error pop-ups if location tracking is blocked. Re-open if this is not the case

bmweis commented 4 years ago

Good call with that one. I try to keep my location sharing turned off with all apps unless I need it. Then I turn it on as needed.