refactor: Improved logger usage

Venefilyn commented 2 months ago

This refactor of the usage of our logging is to get away from custom functions that causes attribute errors in editors and IDEs. This will also standarize the usage of logger and the loglevels.

In future PRs we can include changes to include prepare, rollback, and final specific message styles.

Jira Issues:

-

Depends on

1327

Checklist

[ ] PR has been tested manually in a VM (either author or reviewer)
[ ] Jira issue has been made public if possible
[ ] [RHELC-] or [HMS-] is part of the PR title
[ ] GitHub label has been added to help with Release notes
[ ] PR title explains the change from the user's point of view
[ ] Code and tests are documented properly
[ ] The commits are squashed to as few commits as possible (without losing data)
[ ] When merged: Jira issue has been updated to Release Pending if relevant

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 79.72973% with 30 lines in your changes missing coverage. Please review.

Project coverage is 96.09%. Comparing base (d603f04) to head (943cec0). Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
convert2rhel/phase.py	57.69%	18 Missing and 4 partials :warning:
convert2rhel/main.py	82.35%	2 Missing and 4 partials :warning:
convert2rhel/logger.py	66.66%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1373 +/- ## ========================================== - Coverage 96.59% 96.09% -0.51% ========================================== Files 71 72 +1 Lines 5113 5174 +61 Branches 883 896 +13 ========================================== + Hits 4939 4972 +33 - Misses 98 119 +21 - Partials 76 83 +7 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1373/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1373/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.61% <78.47%> (-0.46%)` | :arrow_down: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1373/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.46% <79.16%> (-0.47%)` | :arrow_down: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1373/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.59% <79.72%> (-0.46%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

has-bot commented 2 months ago

/packit test --labels sanity

Comment generated by an automation.

Log | Bot Usage

Venefilyn commented 2 months ago

/packit test --labels sanity

Venefilyn commented 2 months ago

/packit test --labels sanity

Venefilyn commented 2 months ago

/packit test --labels sanity

Venefilyn commented 2 months ago

/packit test --labels sanity

Venefilyn commented 2 months ago

/packit build

Venefilyn commented 2 months ago

/packit test --labels sanity

Venefilyn commented 2 months ago

/packit test --labels sanity

hosekadam commented 2 months ago

/packit test --labels sanity

hosekadam commented 2 months ago

/packit test --labels sanity