Closed hosekadam closed 1 day ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.12%. Comparing base (
7c3db22
) to head (3ba3fe6
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Note for reviewers:
I used the singleton pattern as we don't exactly know the order of actions and possible where the repo.py
would be imported. If we decide to create an instance inside the repo.py
we can end up preparing the disablerepo
list when we don't actually need it (and possibly the analysis can fail in earlier actions).
This solution creates an instance when it's needed and also the list is prepared only once (it can be a bit time-consuming in case of many unreachable repos)
EDIT: One thing which is left is to comment the unit tests, but the rest is ready for review.
/packit test --labels tier0
/packit retest-failed
/packit test --labels tier0
The failure of /tests/integration/tier1/destructive/system-not-up-to-date/system_not_updated
is a false negative and to be fixed in #1423
/packit test --labels tier0
Not a problem coming with this PR (it's been like that for quite a while) but just for the record - there's a corner case where:
rhel
that they want to use for the conversion (e.g. my-kernel-rebuild)convert2rhel --enablerepo=my-kernel-rebuild
/packit test --labels tier0
Avoid reaching unaccessible repositories provided by user using --enablerepo argument. Those repos are manually disabled during analysis, but when user provides unreachable repo the analysis would fail.
This change adds check if provided repos are accessible - if not, those unaccessible ones are removed from the list for manual disable during analysis.
Jira Issues:
Checklist
[RHELC-]
or[HMS-]
is part of the PR titleRelease Pending
if relevant