oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux and CentOS Stream to Red Hat Enterprise Linux
GNU General Public License v3.0
104 stars 84 forks source link

[RHELC-967] Verify breadcrumbs source_os #1432

Open Andrew-ang9 opened 1 week ago

Andrew-ang9 commented 1 week ago

When you get to the end of the conversion and you go to check the system information in the migration results some of the data isn't actually filled in primarily the source_os isn't set and is still null. This PR adds in a check to see if any of the migration results are set.

Jira Issues:

Checklist

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 35.29412% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5be973f). Learn more about missing BASE report. Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
convert2rhel/breadcrumbs.py 35.29% 16 Missing and 6 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1432 +/- ## ======================================= Coverage ? 92.21% ======================================= Files ? 72 Lines ? 5205 Branches ? 902 ======================================= Hits ? 4800 Misses ? 307 Partials ? 98 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1432/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.10% <35.29%> (?)` | | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.23% <35.29%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: