oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux and CentOS Stream to Red Hat Enterprise Linux
GNU General Public License v3.0
104 stars 84 forks source link

[RHELC-1728] Don't update RHSM facts with sub-man not present #1435

Closed bocekm closed 2 days ago

bocekm commented 6 days ago

When an exception gets raised early before have a chance to install sub-man (for instance when any of the packages installed on the systems are not of the latest version available), convert2rhel hard stops with a traceback when trying to call sub-man which hasn't been installed.

Jira Issues:

Checklist

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.09%. Comparing base (40f5d6e) to head (f9f0cd7). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1435 +/- ## ======================================= Coverage 96.09% 96.09% ======================================= Files 72 72 Lines 5142 5146 +4 Branches 888 889 +1 ======================================= + Hits 4941 4945 +4 Misses 119 119 Partials 82 82 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1435/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.58% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.44% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.57% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

has-bot commented 3 days ago

/packit test --labels tier0


Comment generated by an automation.

Log | Bot Usage
danmyway commented 2 days ago

/packit test --labels tier0