search

oasis-open / cti-stix-common-objects

OASIS Cyber Threat Intelligence (CTI) TC: A repository for commonly used STIX objects in order to avoid needless duplication. https://github.com/oasis-open/cti-stix-common-objects
BSD 3-Clause "New" or "Revised" License
84 stars 36 forks source link

$id values on schema need to be updated #62

Closed dunkeki closed 7 months ago

dunkeki commented 7 months ago

The schema $id values - which are used to set the URI context for $ref appearing within the schema - still reflect the old directory names, e.g.

extension-definition-specifications/acs-marking-definition-3a6/extension-definition--3a65884d-005a-4290-8335-cb2d778a83ce.json

has

"$id": "https://raw.githubusercontent.com/oasis-open/cti-stix-common-objects/main/extension-definition-specifications/**acs-data-markings/**extension-definition--3a65884d-005a-4290-8335-cb2d778a83ce.json",

but should be

"$id": "https://raw.githubusercontent.com/oasis-open/cti-stix-common-objects/main/extension-definition-specifications/**acs-marking-definition-ea6**/extension-definition--3a65884d-005a-4290-8335-cb2d778a83ce.json",

Sorry, but your renaming decision is creating a significant ripple effect, thanks.

dunkeki commented 7 months ago

(the markdown is wrong on the URIs, sorry, but I think you get the idea, thanks)

rpiazza commented 7 months ago

@dunkeki - another great catch. So glad you are finding them. Unfortunately, we don't currently have any testing for this repository. It should be fixed now - reopen if not.