search

oasis-open / cti-stix-common-objects

OASIS Cyber Threat Intelligence (CTI) TC: A repository for commonly used STIX objects in order to avoid needless duplication. https://github.com/oasis-open/cti-stix-common-objects
BSD 3-Clause "New" or "Revised" License
84 stars 36 forks source link

adding allOf to PAP schema and adding PAP:CLEAR #73

Closed ghackford-mitre closed 5 months ago

ghackford-mitre commented 5 months ago

This PR adds PAP:CLEAR to the examples, schema, and adoc files. It also adds an AllOf clause to the PAP JSON schema. Per conversation with Chris, there may be some differences in the PAP schema in contrast to the CUI schema for a couple reasons. The CUI spec explicitly restricts some items, such as definition_type, while the PAP spec does not. However, both schemas include required elements in the AllOf clause e.g. properties, required, etc.

rpiazza commented 5 months ago

@clenk @ghackford-mitre,

The CUI spec explicitly restricts some items, such as definition_type, while the PAP spec does not.

Those properties are deprecated, and shouldn't be used with extension definitions. If the PAP spec doesn't explicitly say the same thing as the CUI one, we should update the PAP spec.

rpiazza commented 5 months ago

Also I have never seen "$definitions". If should be just "definitions".

Also, drop the Word doc file - we won't be keeping that up to date

ghackford-mitre commented 5 months ago

Regarding "definitions" - My IDE gives me a big warning when using "definitions" saying that value is deprecated. Checking up on it, I found this: https://json-schema.org/draft/2019-09/release-notes#semi-incompatible-changes. Should I still use regular "definitions" over "$defs" for consistency with the other schema?

rpiazza commented 5 months ago

I guess we will go with $defs :-)