oasis-tcs / virtio-spec

OASIS Virtual I/O Device TC: Source code for the VIRTIO (Virtual I/O) Specification maintained by the OASIS Virtual I/O Device (VIRTIO) Technical Committee
https://github.com/oasis-tcs/virtio-spec
Other
241 stars 72 forks source link

virtio-blk: Fix incorrect data type of field num_queues #195

Closed paravmellanox closed 1 month ago

paravmellanox commented 6 months ago

Problem: num_queues was written as u16. It should be le16.

Fix: https://lore.kernel.org/virtio-comment/hqicqs6p5h4r4xcdhmathfiegvcaly76ityqe67erj7c4b65ck@d2n6v53is5ya/T/#m6fc5341ecf3a68b5fc63ed5cd1b231aa2fb99961

mstsirkin commented 5 months ago

the link seems to point to review comments not the proposal. Fix it pls and we can vote.

paravmellanox commented 5 months ago

Fixed the link.

mstsirkin commented 5 months ago

BALLOT CREATED AT URL: https://groups.oasis-open.org/higherlogic/ws/public/ballot?id=3832

paravmellanox commented 1 month ago

Following commit fixes the issue: 18e47c0 virtio-blk: Fix data type of num_queues field