search

oasisprotocol / adrs

Architectural Decision Records
2 stars 1 forks source link

ADR 14: Fix secp256k1 signature size #14

Closed matevz closed 1 year ago

matevz commented 1 year ago

Followup to #13 . The size of the secp256k1 signature was also off by 1.

matevz commented 1 year ago

We do not need the public key recovery feature, so the (r, s) components (=2 * 32 bytes) of the ECDSA signature is sufficient. The implementation we're using currently also uses (r, s) only: https://github.com/btcsuite/btcd/blob/718d268a8cf55af9b329bac9e171009352fbc10a/btcec/schnorr/signature.go#L37-L41. Closing.