search

obipawan / react-native-dash

A super simple <Dash /> component for react-native to draw customisable dashed lines
176 stars 63 forks source link

rounded dots instead of dashes #2

Closed RobbyAI closed 7 years ago

RobbyAI commented 7 years ago

I tried to fork your repository to add a 'rounded' property to allow the creation of rounded dots instead of the default straight lines dashes but it seems that you have restricted the forks access so here is my add-on to Dash.js

LINE 19, 20 let borderRadius = rounded ? 100 : 0; let overflow = rounded ? 'hidden' : 'visible';

LINE 33: <View key={i} style={{backgroundColor, width, height, marginRight, marginBottom, borderRadius, overflow}}/>

LINE 49 rounded: React.PropTypes.bool

LINE 57 rounded: false

obipawan commented 7 years ago

Hey @superbibi

Thanks for the addition! I haven't introduced any restrictions to the repo myself. What do you see when you try to fork?

RobbyAI commented 7 years ago

From either Github for Desktop screen shot 2017-04-13 at 9 20 57 am where the push button stay grey.

screen shot 2017-04-13 at 9 21 15 am

or Atom:

screen-shot-2017-04-13-at-9 40 36-am

But I'm probably doing something wrong.

obipawan commented 7 years ago

Ah I see. You'll need to first fork the repo :) and push your changes to your fork and then submit a PR here. please refer https://help.github.com/articles/creating-a-pull-request-from-a-fork/

RobbyAI commented 7 years ago

:/ My bad... I have two GitHub accounts and I'm not logged in with the same on the web and on my laptop IDE

Fork submit.