search

obipawan / react-native-dash

A super simple <Dash /> component for react-native to draw customisable dashed lines
176 stars 63 forks source link

dashColor removed from v0.0.4 #5

Closed garthenweb closed 7 years ago

garthenweb commented 7 years ago

in https://github.com/obipawan/react-native-dash/commit/1b2a1c9296bf73ee513bd0534872ddd574b194ab the dashColor property was removed from the API, the only remaining references are in the PropType declaration and in the readme.

Was this an intended step or an accident?

I would like to keep the dashColor because it feels more natural than passing a backgroundColor into the dashStyle property.

obipawan commented 7 years ago

That was a miss. It was intentionally removed as dashColor felt redundant when you can get it done with the dashStyle. Although, I'm open to it being included again as a prop (which can be overridden by dashStyle)