search

objectionary / opeo-maven-plugin

Maven plugin to remove Bytecode opcodes from XMIR as much as possible
http://www.objectionary.com/opeo-maven-plugin/
MIT License
7 stars 2 forks source link

OpcodeName.java:37-39: Code duplication with... #75

Open 0pdd opened 10 months ago

0pdd commented 10 months ago

The puzzle 65-ca6c046e from #65 has to be resolved:

https://github.com/objectionary/opeo-maven-plugin/blob/0008217aa06baf99a61aab369934cb24b66fc9cb/src/main/java/org/eolang/opeo/ast/OpcodeName.java#L37-L39

The puzzle was created by @rultor on 15-Jan-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be \"done\" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

h1alexbel commented 1 month ago

@volodya-lombrozo can I take this one?

volodya-lombrozo commented 1 month ago

@h1alexbel Sure, please, go ahead! This issue might be tricky, so don't hesitate to ask for help or explanation.

h1alexbel commented 1 month ago

@volodya-lombrozo is it closed by mistake? The puzzle still in the source code

h1alexbel commented 1 month ago

@volodya-lombrozo my bad actually. Looks like I referenced in pull request description here: https://github.com/objectionary/jeo-maven-plugin/pull/771#issue-2597538696. We should reopen this

h1alexbel commented 1 month ago

@volodya-lombrozo after we released 0.6.7, and 0.6.8. In OPEO, we don't have two classes that was imported from JEO 0.5.7: org.eolang.jeo.representation.directives.DirectivesData, org.eolang.jeo.representation.xmir.HexString. I will checkout their implementation in 0.5.7 JEO release, and try to inline them somehow into required classes, without a need to introduce new classes. WDYT?

volodya-lombrozo commented 1 month ago

@h1alexbel Oh, sorry, I missed that as well. Reopen it.

volodya-lombrozo commented 1 month ago

@h1alexbel We significantly changed the jeo-maven-plugin and current implementation of the opeo-maven-plugin is extremely outdated. Maybe it's better to update opeo-maven-plugin according with these changes first. Let's me do it. It might take a couple of days, I guess.

volodya-lombrozo commented 1 month ago

@h1alexbel you can track the progress here.

h1alexbel commented 1 month ago

@volodya-lombrozo got it

0crat commented 1 month ago

@0pdd Hey there, awesome job on that enhancement suggestion! 🎉 You've just snagged yourself 8 bonus points - that's our team policy for accepted enhancements. Keep those great ideas coming! And hey, if you spot anything in the repo that doesn't look quite right, don't hold back - report those bugs too. Your keen eye helps us all improve!

0pdd commented 1 month ago

@0pdd Hey there, awesome job on that enhancement suggestion! 🎉 You've just snagged yourself 8 bonus ...

I see you're talking to me, but I can't reply since I'm not a chat bot.

0pdd commented 1 month ago

@0pdd Hey there, awesome job on that enhancement suggestion! 🎉 You've just snagged yourself 8 bonus ...

I see you're talking to me, but I can't reply since I'm not a chat bot.