Fix: Accordion content blinking

oblador / react-native-collapsible

Animated collapsible component for React Native, good for accordions, toggles etc

MIT License

2.46k stars 452 forks source link

Closed truph01 closed 2 months ago

truph01 commented 5 months ago

This PR will fix the issue https://github.com/oblador/react-native-collapsible/issues/473. We also encountered that bug in our project https://github.com/Expensify/App/issues/43397
Here is the result after the fix:

truph01 commented 5 months ago

@oblador Can you help review this PR once you have a chance? Thanks

oblador commented 4 months ago

Hi, thanks for your PR! When I tested there's still junk on Android (iOS looks fine from what I can tell):

truph01 commented 4 months ago

@Pujan92 Can you reproduce the issue on Android after applying the fix? It works well from my side:

Pujan92 commented 4 months ago

It works well for me too. @oblador Could you plz check one more time on your side?

Before	After Fix

Pujan92 commented 4 months ago

Gentle bump for recheck @oblador

Pujan92 commented 4 months ago

Tried the example code with the functional component and was not able to reproduce the mentioned bug for android.

truph01 commented 4 months ago

@oblador Can you help review the PR? Thanks

truph01 commented 3 months ago

@oblador Any update on the PR review?

Thx

Pujan92 commented 2 months ago

Thanks @oblador for the review and merge :)