search

obrankosi / gitiles

Automatically exported from code.google.com/p/gitiles
0 stars 0 forks source link

404 from diff page parent blame link #50

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1.  Visit 
https://chromium.googlesource.com/chromium/src/+blame/master/content/renderer/re
nder_view_impl.cc
2. On that page, click the "diff" link on the fifth line 
(https://chromium.googlesource.com/chromium/src/+/310ebd630b77e0f3883647ebcf7458
b2010f0a51%5E%21/content/renderer/render_view_impl.cc)
3. On that page, click the parent "blame" link: 
https://chromium.googlesource.com/chromium/src/+blame/0c49552feeb890c8ea1f2f7f85
bc249e9808a815/content/renderer/render_view_impl.cc

What is the expected output? What do you see instead?

I'm not sure what I expected; I was exploring.  What I *got* was a 404, which I 
don't think is intended.

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by rdsmith@chromium.org on 6 May 2014 at 4:05

GoogleCodeExporter commented 8 years ago 
You can see from the diff that the file was added in that commit. We should 
just not include the parent blame link in that case. Thanks for the report.

Original comment by dborowitz@google.com on 6 May 2014 at 7:25