search

observablehq / examples

Examples of using Observable in a variety of contexts
106 stars 33 forks source link

improve examples #10

Closed mbostock closed 3 years ago

mbostock commented 3 years ago

Fixes #7. Fixes #9.

Also improves a variety of details in the examples, such as using ResizeObserver to for the fluid width and height, using the Inspector constructor instead of Inspector.into, and using module.redefine instead of creating a custom standard library where possible.

mbostock commented 3 years ago

Re. return values, it doesn’t matter in this case what observer.fulfilled returns, but still probably a good practice to return undefined. FWIW, you can also avoid that with the void operator.

I’m going to followup with another PR that rewrites the simple-constant example to be more name appropriate and read the value of a constant out of a notebook using module.value. And I’ll rename the current simple-constant example to simple-notebook.