obsidianmd / obsidian-clipper

Highlight and capture the web in your favorite browser. The official Web Clipper extension for Obsidian.
https://obsidian.md/clipper
MIT License
1.09k stars 59 forks source link

BUG: Instructables pages don't clip user visible content #196

Closed jwhitley closed 2 days ago

jwhitley commented 1 week ago

Version (please complete the following information):

Describe the bug

  1. Visit https://www.instructables.com/A-Simple-Drill-Press-Tray/
  2. Clip the page

The visible page content, what a user would obviously expect to have clipped, isn't selected. Instead, some obscure privacy notice content embedded on the page but not normally (or ever?) visible is clipped and none of the visible page content is clipped. This only happens on some pages, but not all; I haven't identified a pattern one way or another.

Expected behavior

The expected user visible content should be selected for clipping.

URLs where the bug occurs

An example of a correct page on this site:

Your template file

Default template is in use.

jwhitley commented 1 week ago

For comparison, MarkDownload clips the expected page content and none of the weird privacy text.

jwhitley commented 1 week ago

huh, interesting. Using this extension on an affected page after clipping with MarkDownload works as expected. That's probably a red-herring from MarkDownload modifying the page in some way, but I thought it worth mentioning. [EDIT: at first I thought this bug was intermittent, before I realized the above interaction.]

I added an example of the "wrong" clip text to this gist: https://gist.github.com/jwhitley/da55ab9cef28547083e6d9103e7fb119

kepano commented 1 week ago

This can be solved using a template and the selector {{selector:article|markdown}}. Please make sure to review Troubleshooting instructions.

jwhitley commented 1 week ago

@kepano, thanks! If I understand correctly, that selector is effectively a workaround for Readability’s behavior. Is that correct? Mostly, I’m trying to understand if I should look for and/or file an upstream issue.