Type enclosing from inside recursive type def

ocaml / merlin

Context sensitive completion for OCaml in Vim and Emacs

https://ocaml.github.io/merlin/

MIT License

1.59k stars 232 forks source link

Type enclosing from inside recursive type def #1805

Closed voodoos closed 3 months ago

voodoos commented 4 months ago

Merlin used to stack-overflow when querying type-enclosing from inside a recursive type definition with verbosity >= 1. This is no longer the case as shown in these two tests. However the results are unsatisfying because the environment around the cursor is not aware of the recursive definition.

Closes #1335 and #1755

ncik-roberts commented 3 months ago

Do you know when or how this was fixed in merlin?

voodoos commented 3 months ago

Unfortunately we don't know which change stopped Merlin from crashing in these cases. My guess would be that it is indeed the result of merging upstream changes to the Printtyp module.