Exposes some helper for reducing direct typedtree usage in Lsp

ocaml / merlin

Context sensitive completion for OCaml in Vim and Emacs

https://ocaml.github.io/merlin/

MIT License

1.59k stars 232 forks source link

Exposes some helper for reducing direct typedtree usage in Lsp #1811

Closed xvw closed 2 months ago

xvw commented 2 months ago

Introduction of a module Merlin_analysis.Typedtree_utils that can be used in lsp. Here, it introduces two function to refactor inferInterface and actionInline.

xvw commented 2 months ago

Taking account of your feedbacks @voodoos, thanks! Two question:

I don't think that kind of refactoring deserve a CHANGE entry
Misc_utils.Compat (now Typedtree_utils.Compat) seems not used, even in ocaml-lsp, should we keep it?

voodoos commented 2 months ago

* `Misc_utils.Compat` (now `Typedtree_utils.Compat`) seems not used, even in `ocaml-lsp`, should we keep it?

It is not used because we eventually did not make a multi-version release of ocaml-lsp. I would keep it for now, it should be useful when we try again to to it. (No need to keep the Compat module however, you can extract the functions that are inside.)

xvw commented 2 months ago

Done!