search

ocaml / merlin

Context sensitive completion for OCaml in Vim and Emacs
https://ocaml.github.io/merlin/
MIT License
1.59k stars 232 forks source link

Some UI improvement for `emacs/merlin-search` #1814

Closed xvw closed 2 months ago

xvw commented 2 months ago

Since polarity research output a result in a popup that take the focus, the user experience was a little bit complicated. So the patch returns the result inside a dedicated buffer:

image

(I was not able to take a screenshot about the "before", because the popup was taking the focus...)

xvw commented 2 months ago

The formatting changes make it inconvenient to review the final diff but the changes look reasonable to me.

I can try to remove the formatting.