Closed dra27 closed 2 years ago
@gerdstolpmann - OCaml 5.0.0~alpha1 is out. Would it be possible to have a 1.9.6 release with this and https://github.com/ocaml/ocamlfind/pull/54, please?
@dra27 This looks good, just one suggestion for improvement. I can release on this weekend (btw., sorry for the delay, it was a very busy year so far).
No problem at all, @gerdstolpmann! Rebased and updated. findlib hasn't supported OCaml 3.x since 1.8.0 when 23cafe184a5899946599ceda4583e3ee32cef69a introduced a use of String.map
(which is a 4.00 stdlib function). I've hardened the configure
script as suggested for OCaml 3.x, regardless - and also fixed a typo from an earlier OCaml 5 related change.
findlib has been 3.08+ since findlib 1.1! It's up to you, but 3.08-3.12 can be "re-supported" with these three commits which are in the "old-compilers" branch of my fork:
String.map
and Lazy.from_fun
which were both introduced in OCaml 4.00ocamlc -opaque
for ocmalopt -g
(which was introduced in OCaml 3.10)Nice! I'll apply these patches.
This is an update of #45, compatible with the latest version pushed to ocaml/ocaml#11007. The current proposal is that from OCaml 5.0.0~alpha1, the compiler installs its own
META
files in directories under the Standard Library directory.The previous version was not able to guarantee the operation of Dune or opam's
ocaml-system
because there wasn't a mechanism for reliably determining the location of the compiler'sMETA
files. The latest revision proposes that the compiler'sMETA
are therefore always installed in the same place, with Dune and ocamlfind using that fact to change their default search paths for packages accordingly.This PR, therefore:
runtime_events
META
file, since findlib never needs to build itconfigure
never to generateMETA
files for the compiler for 5.0+path
infindlib.conf
(unless findlib is configured with-sitelib $(ocamlc -where)
as this is then unnecessary)The last part requires a small tweak for Windows to take advantage of the fact that
cygpath
knows how to translatePATH
-style variables.