search

ocean-tracking-network / glatos

9 stars 4 forks source link

WIP: Resolve "position_heat_map - kmz output works on Mac but not on Windows" - [opened] #159

Closed jdpye closed 2 years ago

jdpye commented 2 years ago

In GitLab by @trbinder on Feb 20, 2020, 15:05

_Merges 96-position_heatmap-kmz-output-works-on-mac-but-not-on-windows -> main

Closes #96

jdpye commented 2 years ago

In GitLab by @jdpye on Nov 30, 2021, 12:39

changed target branch from master to main

trbinder commented 2 years ago

This error is the product of the fact that zip::zip seems to work differently on Windows and Macs. The issues is resolved by replacing the zip::zipr function call on or around line 452 with the following code, which calls the function differently depending on operating system.

if(Sys.info()['sysname']=="Darwin"){ zip::zip(zipfile = file.path(paste0(folder, "/", fish_posint,"", abs_or_rel, ".kmz")), files = c(file.path(paste0(folder, "/", fish_posint,"", abs_or_rel,".kml")), file.path(paste0(folder, "/", fish_posint,"", abs_or_rel,".png"))), mode="cherry-pick") }else{ zip::zip(zipfile = file.path(paste0(folder, "/", fish_posint,"", abs_or_rel, ".kmz")), files = c(file.path(paste0(folder, "/", fish_posint,"", abs_or_rel,".kml")), file.path(paste0(folder, "/", fish_posint,"", abs_or_rel,".png")))) }