search

ocean-tracking-network / glatos

9 stars 4 forks source link

Include CRS attribution to att_obj to replicate ATT object in VTrack - [closed] #163

Closed jdpye closed 2 years ago

jdpye commented 2 years ago

In GitLab by @vudyawer on Nov 30, 2019, 23:50

Merges patch-1 -> master

jdpye commented 2 years ago

In GitLab by @chrisholbrook on Feb 17, 2020, 23:39

added 1 commit

Compare with previous version

jdpye commented 2 years ago

In GitLab by @chrisholbrook on Feb 17, 2020, 23:50

Thanks for catching this @vudyawer. if (inherits(crs, "CRS")) couldn't be evaluated if missing (Error... "argument crs is missing"), so I set default crs = sp::CRS("+init=epsg:4326"). Any reason not to do this? @ryangosse

jdpye commented 2 years ago

In GitLab by @jdpye on Feb 27, 2020, 14:15

Definitely the way I have had to solve it in the wild just today.

Do we anticipate anyone building ATT objects from GLATOS/OTN data with other coordinate reference systems? I don't imagine we would? If we're happy to believe the only input coordinate data are going to be decimal lat/lon we won't have any trouble with including the CRS like above.

jdpye commented 2 years ago

In GitLab by @chrisholbrook on Feb 27, 2020, 23:50

epsg:4326 is the standard for GLATOS, so that as default is a good fit for us

jdpye commented 2 years ago

In GitLab by @chrisholbrook on Apr 23, 2021, 22:48

mentioned in commit 90f71899e03202c521dc94161226c36e7bba6075

jdpye commented 2 years ago

In GitLab by @chrisholbrook on Apr 23, 2021, 22:49

closed with 90f7189