search

ocean-tracking-network / glatos

9 stars 4 forks source link

Modernized examples in animation functions, fixed data.table error in summarize_detections #192

Closed haydento closed 10 months ago

haydento commented 10 months ago

Updated examples in animation functions (not critical, original works as written, just trying to move from raster to terra), added ability to submit a terra::spatVector format as background map to detection_bubble_plot (not critical, works as is), and fixed summarize_detections (this one does impact usage of function) bug that reported "glatos_array" when summarize_detections was called with default values i.e.,

get path to example detection file

  det_file <- system.file("extdata", "walleye_detections.csv", package = "glatos")
  det <- read_glatos_detections(det_file)
  ds <- summarize_detections(det = det, location_col = "glatos_array", receiver_locs = NULL, animals = NULL, summ_type = "animal")
jdpye commented 10 months ago

Big merge comin here! Looking through this while trying to sort out the auto-build. I'm going to have to drop GISTools from the dependencies, would this PR have a recommended replace for the one spot we use that package, over in detection_range_handout.Rmd ?

jdpye commented 10 months ago

Chatted with @chrisholbrook , he suggested changing the base of this to dev and that cleaned up what was going on significantly.

jdpye commented 10 months ago

looks like a code linter really had its way with a few of these files. Hope I picked the right side of things, the whole file was marked as the diff but nothing substantive outside of whitespace and the great_lakes_poly changes were apparent to me.

jdpye commented 10 months ago

I looked into the linting, it's the styler package that gets called via the Style GHA. It's using the 'tidyverse recommended style guide' so that's where it's coming from. Probably a benefit to us in the end to have this running and looking over our shoulders.