dev DESCRIPTION PR fix - Githubissues

ocean-tracking-network / glatos

9 stars 4 forks source link

dev DESCRIPTION PR fix #193

Closed mhpob closed 10 months ago

mhpob commented 10 months ago

Adding back in the changes I accidentally undid when addressing the merge conflict in https://github.com/ocean-tracking-network/glatos/pull/187/commits/c3ae7e202063b4034d3f455a646421e407305d77.

Add dplyr to Imports
Remove plyr from Imports

jdpye commented 10 months ago

I was about to dig into where and how we use sp, it looks like the changeover from greatLakesPoly to great_lakes_poly needs to happen in a few of the vignettes and handouts but nothing in actual package code is implicated. I think we lose sp and fix the vignettes, and possibly in that order.

mhpob commented 10 months ago

I opened #194 for discussion. I removed the sp issue from this PR since it involves some bigger conceptual changes like you've outlined.

jdpye commented 10 months ago

yeah, I think between this PR and https://github.com/ocean-tracking-network/glatos/pull/192/ we are most of the way home on removing sp