ocean-tracking-network / glatos

9 stars 4 forks source link

Pass R CMD check with no errors #214

Closed mhpob closed 9 months ago

mhpob commented 9 months ago

R CMD check should complete without errors (only warnings!) after review/acceptance of this.

List of changes:

mhpob commented 9 months ago

@jdpye could I ask you (or anyone else) to run devtools::document or roxygen2::roxygenize on this PR and commit? I have a weird system specific thing preventing me from doing so.

It should fix the last R CMD check error... Or let it progress down the line to the next error it hasn't gotten to yet.

jdpye commented 9 months ago

I'll give it a shot today, yep!

jdpye commented 9 months ago

Mike, I think you won out!

mhpob commented 9 months ago

@chrisholbrook @jdpye I hope you weren't getting hammered with all of those notices, but if you were...

GLATOS NOW PASSES R CMD CHECK!

(ish. Warnings still need to be addressed, but now if we don't get the pretty green check marks after a commit you know that something is probably not good.)

chrisholbrook commented 9 months ago

GLATOS NOW PASSES R CMD CHECK!

@mhpob Wow! Can't thank you enough for incredible mop up effort here! also @jdpye for keeping momentum.

Confirming as of now (https://github.com/ocean-tracking-network/glatos/commit/f016ab1538634e6368da7b80411046d2251ef253) passes devtools::check() for me locally:

image