search

oceanmodeling / adcirc

ADCIRC Model Repository
https://adcirc.org
Other
0 stars 0 forks source link

Implement DataInitialize #3

Open uturuncoglu opened 9 months ago

uturuncoglu commented 9 months ago

@pvelissariou1 @yunfangsun @janahaddad @saeed-moghimi-noaa The NUOPC_Label_DataInitialize needs to be specialized for the ADCIRC to exports component fields during initialization or restart. This is not done in the current version of the NUOPC cap and might be required for the reproducibility. This requires extensive restructuring cap.

pvelissariou1 commented 9 months ago

@uturuncoglu So the ADCIRC NUOPC cap is not working as expected. How long to fix this?

uturuncoglu commented 9 months ago

@pvelissariou1 The cap is working since we are not testing restart capability of the component at this point. I think I could create an issue like SCHSIM in the reproducibility (magically we have no that issue now) since ocean mask is not available in the initialization phase of the mediator. So, this is not an urgent fix but must be fixed. It is not a too much work but since these caps are not developed by following the exiting convention etc. It could take little bit longer because I also split the advance call and create others calls just for dedicated to update import and export states.

pvelissariou1 commented 9 months ago

@uturuncoglu Ok, thanks. Please create an issue so we can keep track.

uturuncoglu commented 9 months ago

@pvelissariou1 Sure. ROMS has no this issue since it is developed by testing retorts etc. and has robust testing mechanism. BTW, I have already implemented for SCHSIM. It is in a fork at this point and created a draft PR.