search

ocombe / ocLazyLoad

Lazy load modules & components in AngularJS
https://oclazyload.readme.io
MIT License
2.63k stars 510 forks source link

Provide the loader with created elements #292

Closed msak closed 8 years ago

msak commented 8 years ago

Your loader decorators are very straight forward and can be overridden for custom purpose. But I miss the possibility to get access to the elements created by buildElement.

It would be great if you could accept this request with my little change.

ocombe commented 8 years ago

Sure, could you change it in the sources instead of the dist folder please ?

msak commented 8 years ago

Shame on me :) Do you able to take the second commit from this pull request, or should I create a new one?

ocombe commented 8 years ago

If you add a commit to the same branch, it will be added to the PR (which is what you did).

msak commented 8 years ago

So already done!

If you merge, when will be a new npm package created?

ocombe commented 8 years ago

I'll try to make a new release this week end.

msak commented 8 years ago

Great! Thanks!

msak commented 8 years ago

Hi Olivier, could you create a new npm package?

kination commented 8 years ago

Hello @msak . If it's okay, could you remove the changes on /dist files?

ocombe commented 8 years ago

they will be overwritten when you rebuild them anyway @djKooks

kination commented 8 years ago

Oh, okay. Just want to make sure.

kination commented 8 years ago

@ocombe It looks fine to merge this. How do you think?

ocombe commented 8 years ago

Yes :)

ocombe commented 7 years ago

I just released 1.1.0 with this, I think I did it right, I haven't published a new version on this repo for ages, let me know if it works